Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix toolz and cytoolz code #111

Closed
pipermerriam opened this issue Jun 21, 2018 · 1 comment · Fixed by #138
Closed

Fix toolz and cytoolz code #111

pipermerriam opened this issue Jun 21, 2018 · 1 comment · Fixed by #138
Labels
Good First Issue
Milestone
1.0 stable release

Comments

@pipermerriam
Copy link
Member

pipermerriam commented Jun 21, 2018 •
edited
Loading

What was wrong?

Right now all imports come from cytoolz. However, our setup.py module is setup to conditionally install either cytoolz or toolz depending on whether we're on Cython or pypy. This means that a pypy installation (which we aren't currently testing against) will fail because cytoolz won't be installed.

How can it be fixed?

Update all toolz/cytoolz imports to import from eth_utils.toolz.
@pipermerriam pipermerriam added this to the 1.0 stable release milestone Jul 23, 2018
@pipermerriam
Copy link
Member Author

Updating to specify using the eth-utils aliases instead.

@stefanmendoza stefanmendoza mentioned this issue Oct 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue
Projects
None yet
Milestone
1.0 stable release
Development

Successfully merging a pull request may close this issue.

Use eth_utils.toolz aliasing for cytoolz/toolz
1 participant
@pipermerriam