Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/geth: Ctrl-C in combination with js causes unclean shutdown #16506

Closed
rustyx opened this issue Apr 15, 2018 · 6 comments
Closed

cmd/geth: Ctrl-C in combination with js causes unclean shutdown #16506

rustyx opened this issue Apr 15, 2018 · 6 comments

Comments

@rustyx
Copy link

rustyx commented Apr 15, 2018

System information

Geth version: 1.8.3-stable
OS & Version: Windows 10 x64

Expected behaviour

Clean shutdown when pressing Ctrl-C while a script is running.

Actual behaviour

Unclean shutdown.

Steps to reproduce the behaviour

  1. Create a file test.js with the following contents:
    eth.filter("latest", function() {});
  2. Start geth js test.js
  3. Once started, press Ctrl+C.
  4. Geth is killed instead of gracefully shutting down.
@stale
Copy link

stale bot commented Apr 16, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot closed this as completed May 28, 2019
@fjl
Copy link
Contributor

fjl commented May 30, 2019

Sorry, that bot can be over-eager sometimes.

@fjl fjl reopened this May 30, 2019
@stale stale bot removed the status:inactive label May 30, 2019
@fjl fjl changed the title Ctrl-C in combination with js causes unclean shutdown cmd/geth: Ctrl-C in combination with js causes unclean shutdown May 30, 2019
@holiman
Copy link
Contributor

holiman commented Jun 4, 2019

Fwiw, I cannot repro this on linux on master (works as it should)

@rustyx
Copy link
Author

rustyx commented Jun 4, 2019

Just tested with 1.8.27 on Windows, the issue is still there. With geth --preload test.js all is fine, but with geth js test.js Ctrl-C causes immediate termination/unclean shutdown.

@ligi
Copy link
Member

ligi commented Oct 24, 2019

Perhaps it's a windows only thing? @FrankSzendzielarz can you try this out?

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants