Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth.syncing broken in snap sync #23584

Closed
verheesj opened this issue Sep 16, 2021 · 2 comments
Closed

eth.syncing broken in snap sync #23584

verheesj opened this issue Sep 16, 2021 · 2 comments

Comments

@verheesj
Copy link
Contributor

The eth.syncing is a bit broken in snap sync, it does not fill in the necessary infos. We need to fix that.

Originally posted by @karalabe in #23553 (comment)

Can we discuss?

@ligi
Copy link
Member

ligi commented Sep 23, 2021

I initiated some discussion some time ago here: https://ethereum-magicians.org/t/improve-syncing-rpc-call/6994 - we should do it in magicians to agree on a standard for RPC here so client's do not diverge even more

@karalabe
Copy link
Member

I have an open PR that will fix this. It's a lot of changes, so will take a while (it's a complete downloader overhaul).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@ligi @karalabe @verheesj and others