Dialer not use discv5

[sonhv0212]

Seem that discv5 source is not used anywhere, the last PR #30302 removes the DialCandidates of the eth protocol that includes discv5 source but that change is not mentioned in the description

[fjl]

WDYM? the linked PR adds discv5 as a nodes source for the dialer!

[sonhv0212]

But seems that it is not passed to the dialer via DialCandidates, you can check this line https://github.com/ethereum/go-ethereum/pull/30302/files#diff-5beb4052baf94e3025566d929c63974350e4b1eae18cce8eb21b4579d6788ffeL117

[fjl]

I checked and I agree the naming is confusing there. The dnsdisc there is the name of the function parameter of MakeProtocols, and we pass Ethereum.discmix to it. The discv5 iterator is a part of this discmix.

The parameter name should be updated. I just left it as-is from before, but that's confusing.

[sonhv0212]

yeah, I see the discv5 iterator is added to Ethereum.discmix, but the dnsdisc is not used in eth.MakeProtocols (the previous version is passed to the dialer via DialCandidates, which will be added to p2p.Server.discmix and then dialer use that discmix to try dialing). So, in this case, the discv5 iterator is useless

[fjl]

Damn, you are right! Thank you!