Skip to content
This repository was archived by the owner on Aug 2, 2021. It is now read-only.

improve error message: Manifest entry for X not found #726

Closed
cobordism opened this issue Jun 18, 2018 · 4 comments · Fixed by ethereum/go-ethereum#18171
Closed

improve error message: Manifest entry for X not found #726

cobordism opened this issue Jun 18, 2018 · 4 comments · Fixed by ethereum/go-ethereum#18171

Comments

@cobordism
Copy link

Example:
When a request is made to bzz://somesite.eth/ and a swarm manifest is found at somesite.eth, but it does not contain a default entry, then we show the error "Manifest entry for ' ' not found"

I think that "Manifest entry for 'XYZ ' not found" / "Manifest entry for ' ' not found" is a very cryptic error message.

I'd like to see something like "The loaded manifest does not contain an entry for XYZ" / "The loaded manifest does not contain a default entry", together with a clickable link to the same manifest with the bzz-list scheme.

@cobordism
Copy link
Author

c.f. #156

@acud
Copy link
Member

acud commented Oct 15, 2018

I think that "Manifest entry for 'XYZ ' not found" / "Manifest entry for ' ' not found" is a very cryptic error message.

I have changed the aforementioned error to: fmt.Errorf("Not found: could not find resource '%s'", path). I think that mentioning manifests in general is cryptic and does not give extra information, since a not found can be either an entry not found but also network could not find since it doesn't exist - the two should be merged into one error message.

I'd like to see something like "The loaded manifest does not contain an entry for XYZ" / "The loaded manifest does not contain a default entry", together with a clickable link to the same manifest with the bzz-list scheme.

this is no longer relevant since we will already fall back to bzz list on http get of a manifest without a default entry.

@cobordism
Copy link
Author

ok. I see. makes sense.

so if manifest does not have default, and I request manifest, we do bzz-list. But what do we do if I request manifest/abc but the manifest does not contain an abc entry? do we also bzz-list?

@acud
Copy link
Member

acud commented Oct 17, 2018

404

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants