Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export CI=true does not execute tests in batch mode #1258

Closed
stefaneg opened this issue Dec 12, 2016 · 7 comments
Closed

Export CI=true does not execute tests in batch mode #1258

stefaneg opened this issue Dec 12, 2016 · 7 comments

Comments

@stefaneg
Copy link

stefaneg commented Dec 12, 2016

If you are reporting a bug, please fill in below. Otherwise feel free to remove this template entirely.

Description

Trying to execute test in CI environment.

Expected behavior

Tests should run and immediately terminate.

Actual behavior

Tests run, but wait for changes/user input.

Environment

npm ls react-scripts
[email protected] /Users/gulli/src/ru/reference-tictactoe-student/client
└── [email protected]

node -v
v6.9.1

npm -v
4.0.3

Then, specify:

OSX Sierra
Browser irrelevant.

Reproducible Demo

clone https://github.com/hgop/reference-tictactoe
cd client
npm install
export CI=true
npm test

Should run tests and exit immediately since CI variable is true according to docs here:

https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#continuous-integration

@existentialism
Copy link
Contributor

existentialism commented Dec 12, 2016

@stefaneg thanks for the issue!

The CI variable was introduced in react-scripts v0.8.0, so please try upgrading.

@gaearon
Copy link
Contributor

gaearon commented Dec 12, 2016

Hmm I think CI variable itself was supported since we added the test runner.

@stefaneg
Copy link
Author

Still does not work for me. Tried 0.8.0 and 0.8.4.

[email protected] /Users/gulli/src/ru/reference-tictactoe-student/client
└── [email protected]

I'm getting the information that this is working for some of my students. I'll post an update when I know more details.

@gaearon
Copy link
Contributor

gaearon commented Dec 12, 2016

I see you have --watchAll in your test command, it probably overrides CI=true.

@existentialism
Copy link
Contributor

Yeah, my mistake.

@stefaneg
Copy link
Author

Yeah, I just realized that. Thank you guys.

@existentialism
Copy link
Contributor

Glad it's solved, sorry again for leading you slightly astray :)

@gaearon gaearon closed this as completed Dec 12, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants