Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect link to PWA documentation in serviceWorker.js #5796

Closed
SeanReece opened this issue Nov 14, 2018 · 1 comment
Closed

Incorrect link to PWA documentation in serviceWorker.js #5796

SeanReece opened this issue Nov 14, 2018 · 1 comment

Comments

@SeanReece
Copy link

In serviceWorker.js the link in the comments inviting the user to learn more about PWA seems to be broken.

// To learn more about the benefits of this model and instructions on how to
// opt-in, read http://bit.ly/CRA-PWA

http://bit.ly/CRA-PWA points to templates/README.md#making-a-progressive-web-app (anchor doesn't exist) when it should (I think) point to facebook.github.io/create-react-app/docs/making-a-progressive-web-app

I don't mind submitting a PR to fix this but I'm assuming that it would be wiser to update the bitlink itself so any links outside this repo will also point to the correct documentation.

Thanks!

@iansu
Copy link
Contributor

iansu commented Nov 14, 2018

Unfortunately bit.ly won't allow us to change those links. I've created a PR to add placeholders in the template README that provide links to the corresponding pages in the docs: #5808

@iansu iansu closed this as completed Nov 14, 2018
@lock lock bot locked and limited conversation to collaborators Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants