Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-react-app is not working in development mode in Microsoft Edge #8484

Closed
burgua opened this issue Feb 13, 2020 · 5 comments
Closed

create-react-app is not working in development mode in Microsoft Edge #8484

burgua opened this issue Feb 13, 2020 · 5 comments

Comments

@burgua
Copy link

burgua commented Feb 13, 2020

Describe the bug

create-react-app is not working in development mode in Microsoft Edge. Production build works.

Environment

Environment Info:

current version of create-react-app: 3.3.1
running from C:\Users\olexi\AppData\Roaming\npm-cache_npx\2716\node_modules\create-react-app

  System:
    OS: Windows 10 10.0.18363
    CPU: (8) x64 Intel(R) Core(TM) i5-8265U CPU @ 1.60GHz
  Binaries:
    Node: 10.15.3 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.15.2 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 6.4.1 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: 44.18362.449.0
    Internet Explorer: Not Found
  npmPackages:
    react: ^16.12.0 => 16.12.0
    react-dom: ^16.12.0 => 16.12.0
    react-scripts: 3.3.1 => 3.3.1
  npmGlobalPackages:
    create-react-app: Not Found

Steps to reproduce

  1. Create new react applications with command npx create-react-app my-app
  2. Open started application in Microsoft Edge browser.

Expected behavior

I see starting application page.

Actual behavior

Browser shows blank page.
Console shows this error: "SCRIPT1028: SCRIPT1028: Expected identifier, string or number".
image

@AmirHMousavi
Copy link

AmirHMousavi commented Feb 14, 2020

Same issue here! Apparently Edge does not support the spread operator

Mie problem is pointing at

const proto = Object.defineProperties(() => {}, {
	...styles,
	level: {
		enumerable: true,
		get() {
			return this._generator.level;
		},
		set(level) {
			this._generator.level = level;
		}
	}
});

@burgua
Copy link
Author

burgua commented Feb 14, 2020

Yep, exactly same line of code.

@burgua
Copy link
Author

burgua commented Feb 14, 2020

It looks like Microsoft Edge is not supporting spread operator for objects. Arrays have no problems.

@burgua
Copy link
Author

burgua commented Feb 14, 2020

Looks like, it is related with #8439.

@burgua
Copy link
Author

burgua commented Feb 17, 2020

Fixed with 3.4.0

@burgua burgua closed this as completed Feb 17, 2020
@lock lock bot locked and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants