Skip to content

Commit 713ed08

Browse files
Nivaldo Bondançafacebook-github-bot
Nivaldo Bondança
authored andcommitted
Removed remaining dropbox style references
Summary: Since this was removed on v0.51, it no longer makes sense to have those around. Ideally this should have happened on [this commit](4a393bb). Reviewed By: cortinico Differential Revision: D58781951 fbshipit-source-id: 9a9d1efcaf554781acc5cacd09bdbd520ee96bfd
1 parent f31448e commit 713ed08

File tree

3 files changed

+4
-103
lines changed

3 files changed

+4
-103
lines changed

CHANGELOG.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,14 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/).
1818

1919
### Changed
2020
- Preserves blank spaces between when clauses (https://github.com/facebook/ktfmt/issues/342)
21-
- Named the default style as `Formatter.META_FORMAT` / `--meta-style`
22-
- `FormattingOptions` constructor parameters order was changed
21+
- Named the default style as `Formatter.META_FORMAT` / `--meta-style` (https://github.com/facebook/ktfmt/commit/96a7b1e2539eef43044f676f60400d22265fd115)
22+
- `FormattingOptions` constructor parameters order was changed (https://github.com/facebook/ktfmt/commit/520706e6d010d48619781d7113e5b1522f07a2ba)
2323

2424
### Fixed
2525
- Compilation issues with online formatter (https://github.com/facebook/ktfmt/commit/8605080cb0aadb7eaba20f3b469d6ddafe32c941)
2626
- Removing valid semicolons (https://github.com/facebook/ktfmt/issues/459)
2727
- Incorrect detection of unused `assign` import (https://github.com/facebook/ktfmt/issues/411)
2828

2929
### Removed
30-
- **Deleted `Formatter.DROPBOX_FORMAT` / `--dropbox-style` (BREAKING CHANGE)**
31-
- Deleted `FormattingOptions.Style` enum
30+
- **Deleted `Formatter.DROPBOX_FORMAT` / `--dropbox-style` (BREAKING CHANGE)** (https://github.com/facebook/ktfmt/commit/4a393bb8c1156a4a0fd1ab736c02ca8dbd39a969)
31+
- Deleted `FormattingOptions.Style` enum (https://github.com/facebook/ktfmt/commit/7edeff14c3738427e53427eb6e39675dc30d1d05)

core/src/test/java/com/facebook/ktfmt/cli/ParsedArgsTest.kt

-6
Original file line numberDiff line numberDiff line change
@@ -66,12 +66,6 @@ class ParsedArgsTest {
6666
assertThat(parsed.formattingOptions).isEqualTo(Formatter.META_FORMAT)
6767
}
6868

69-
@Test
70-
fun `parseOptions recognizes --dropbox-style`() {
71-
val parsed = assertSucceeds(ParsedArgs.parseOptions(arrayOf("--kotlinlang-style", "foo.kt")))
72-
assertThat(parsed.formattingOptions).isEqualTo(Formatter.KOTLINLANG_FORMAT)
73-
}
74-
7569
@Test
7670
fun `parseOptions recognizes --google-style`() {
7771
val parsed = assertSucceeds(ParsedArgs.parseOptions(arrayOf("--google-style", "foo.kt")))

docs/editorconfig/.editorconfig-dropbox

-93
This file was deleted.

0 commit comments

Comments
 (0)