[TextInput] How do you implement maxLength for TextInput?

[leonlxli]

Is there a way for you to limit the number of characters that you can enter into a textInput similar to how maxLength works?

[brentkirkland]

What if you checked onTextChange if the text was <= the desired length of characters?

[leonlxli]

onChangeText still makes the change. I want to make it so that if the user is not allowed to enter in more than the maxLength. When I used onChangeText, it still changes the input

[brentvatne]

We would need to handle this on the native side, eg: http://stackoverflow.com/questions/2523501/set-uitextfield-maximum-length

Overall, TextInput needs a lot of work. I know @sahrens is working on some improvements now but any community help on this one is very much appreciated!

What we would need to do:

• Look at the maxLength spec for web and ensure we understand all of its behaviours
  • This should be pretty easy - adding keystrokes to the text field contents once the length has reached. Something to consider though - do we provide a hook for the JS side to respond to press events after we have exceeded this? This line of thinking is necessary. We'll need to consider common use cases for maxlength and ensure we can handle those.
• Add a prop to TextInput with the same, make the backing logic on the ObjC side
• Add an example to UIExplorer

[dsibiski]

I implemented shouldChangeCharactersInRange in this PR: #2082 for issue #1882

These two definitely overlap. Would be nice to see a convergence of ideas here.

[sahrens]

This and several fixes landed internally and should sync out this week.

On Jul 22, 2015, at 1:40 AM, Dave Sibiski [email protected] wrote:

I implemented shouldChangeCharactersInRange in this PR: #2082 for issue #1882

These two definitely overlap. Would be nice to see a convergence of ideas here.

—
Reply to this email directly or view it on GitHub.

[brentvatne]

@sahrens - awesome, super excited! thanks!

[browniefed]

@brentvatne this landed into master so this can probably be closed?

[monyxie]

The current implementation doesn't seem to work with Chinese keyboard.

[ide]

Closing this since maxLength has been implemented. Will open a new issue for the problem with Chinese characters.