Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getModifierState browser support comments #13916

Closed
nhunzaker opened this issue Oct 21, 2018 · 3 comments
Closed

Update getModifierState browser support comments #13916

nhunzaker opened this issue Oct 21, 2018 · 3 comments

Comments

@nhunzaker
Copy link
Contributor

We have a few stale comments about getEventModifierState:

// IE8 does not implement getModifierState so we simply map it to the only
// modifier keys exposed by the event itself, does not support Lock-keys.
// Currently, all major browsers except Chrome seems to support Lock-keys.

IE8 isn't an issue anymore, but Safari probably still is. It'd be nice to figure out specifically why we still need this module and update the comment with that info.

@powens
Copy link
Contributor

powens commented Oct 21, 2018

Mind if I take a look at this?

@nhunzaker
Copy link
Contributor Author

Not at all :) Thanks!

@powens
Copy link
Contributor

powens commented Oct 22, 2018

As you mentioned, it appears that the only issue is older versions of Safari (<= 10, according to he caniuse link above). Probably overkill, but I tested a modified create-react-app on Safari 7.1, and the modifierKeyToProp mapping object was used.

It also appears that Chrome now supports Lock-keys. I've removed that note as well.

Let me know if the changes are okay :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants