build/make error

[darrenfu]

Hello there,

When I resync my forked repo, and "rebuild the project" in CLion, I got the following cmake error, I also got the following make error via the command line.

Any ideas?

[mbasmanova]

Try #3295

[darrenfu]

Thanks, @mbasmanova ! The BaseRuntimeStatWriter error is gone, here is a new make error

[mbasmanova]

@darrenfu Try adding FOLLY_NULLABLE to raw pointers the compiler complains about.

[darrenfu]

Thanks @mbasmanova.

If you look at the failure error stacks, they mostly occurred at lines when include a header, such as <optional>, <algorithm>, <memory>, <folly/Range.h>. This is different from fixes like #2026. Since it reports at nullptr in its dep libraries, I have less confidence adding FOLLY_NULLABLE to velox code will help, any other thoughts?

e.g.

In file included from /Users/dofu/git/velox/velox/common/base/RandomUtil.cpp:19:
In file included from /opt/homebrew/opt/llvm/bin/../include/c++/v1/optional:163:
In file included from /opt/homebrew/opt/llvm/bin/../include/c++/v1/__concepts/invocable.h:13:
In file included from /opt/homebrew/opt/llvm/bin/../include/c++/v1/__functional/invoke.h:15:
In file included from /opt/homebrew/opt/llvm/bin/../include/c++/v1/__type_traits/apply_cv.h:16:
In file included from /opt/homebrew/opt/llvm/bin/../include/c++/v1/__type_traits/remove_reference.h:13:
/opt/homebrew/opt/llvm/bin/../include/c++/v1/cstddef:50:9: error: no member named 'nullptr_t' in the global namespace
using ::nullptr_t;

[Update] I tried to resync the forked repo, reinstall most dependency libraries (and upgrade llvm to 15), clean the build folder and rerun "make debug", it doesn't help. Looks like it requires some code fixes for M1 build?
Btw, I'm using Mac M1, macOS v12.6.1, CLion 2022.2.4.

[darrenfu]

@kgpai and I paired and located the issue, it relates to the incompatible versions of my Mac's CommandLineTools and XCode. Once I manually removed the -isystem /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include in the cmake command, the cmake command will pass. I will look into it further for an ultimate fix.

[kgpai]

@darrenfu Can we close this issue if your problem is resolved ?