Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Filter not applied on Test Check #1143

Closed
oturpe opened this issue Jul 24, 2021 · 0 comments · Fixed by #1146
Closed

Version Filter not applied on Test Check #1143

oturpe opened this issue Jul 24, 2021 · 0 comments · Fixed by #1146

Comments

@oturpe
Copy link
Contributor

oturpe commented Jul 24, 2021

While Version Filter is correctly applied when a project is submitted,
it is not applied for the Test check in the add/edit screen.
This makes is unnecessarily difficult to assert that the filter is configured correctly.

To reproduce

Using the Munt project as an example,
since it uses a monorepo where the different component releases
are all mixed up in GitHub releases of a single repo.

Step 1: No filtering

Enter the following items

Click Test check

Observe many results of format <prefix>_<number_with_underscores>

Step 2: Add version prefix

Add the following data:

  • Version prefix: mt32emu_qt_

Click Test check

Observe same results as before,
with entries matching the given prefix
converted to plain <number_with_underscores>.

Step 3: Add version filter

Add the following data which should filter additional entries:

  • Version filter: munt_,mt32emu_win32drv_,mt32emu_smf2wav_,libmt32emu_

Click Test check

Observe that the results did not change.

If you proceed to Submit, the filter is applied correctly in the actual results.
Only the Test check is misbehaving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant