Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecosystem for GNOME projects? #687

Closed
abitrolly opened this issue Jan 7, 2019 · 13 comments · Fixed by #781
Closed

Ecosystem for GNOME projects? #687

abitrolly opened this issue Jan 7, 2019 · 13 comments · Fixed by #781
Assignees
Labels
Low Priority This ticket has a low priority
Milestone

Comments

@abitrolly
Copy link
Contributor

For meld what is the purpose of duplicating Homepage into non-editable Ecosystem field?

image

@Zlopez
Copy link
Contributor

Zlopez commented Jan 7, 2019

We have only few ecosystems right now and these are linked to used backend, if there is no ecosystem for the backend we use the homepage as ecosystem to ensure that the project is unique in the used ecosystem.
The project is considered unique, if there is no project with same name and same ecosystem.

@abitrolly
Copy link
Contributor Author

If there is no ecosystem for GNOME, why expose it at all?

@Zlopez
Copy link
Contributor

Zlopez commented Jan 7, 2019

There is ecosystem for Pypi, Rubygems, Maven, npm and crates, and this information was missing on the project page. So I just made it visible.

@abitrolly
Copy link
Contributor Author

If there is no ecosystem for GNOME, why not just keep this field blank? Why it is needed at all?

@Zlopez
Copy link
Contributor

Zlopez commented Jan 7, 2019

This is only a information for anybody, who wants to see it. Otherwise you need to query database to get this info. In future it will be normalized url to prevent creation of duplicate projects.

@abitrolly
Copy link
Contributor Author

Information is something people understand. I don't understand what is this Ecosystem string in meld project description.

@Zlopez
Copy link
Contributor

Zlopez commented Jan 7, 2019

I need to update the documentation than.

@Zlopez Zlopez added the docs label Jan 7, 2019
@cheese1
Copy link

cheese1 commented Jan 9, 2019

i think @abitrolly meant that this ecosystem-field does not make sense on all occasions.
just because npm, pypi, etc. have ecosystems, which is interesting for that projects, does not mean, that we need that information on all projects, especially on projects without ecosystems.

@Zlopez
Copy link
Contributor

Zlopez commented Jan 10, 2019

I understand, but I wanted to make this information public. Because this is used when checking for duplicity. It is filled everytime, so it's not empty even when the project isn't part of any ecosystem. But if this is distracting, I can't hide it for regular users and show it only to admins.

@jeremycline
Copy link
Member

The fact that we set it to the homepage to enforce a uniqueness constraint is an internal detail that probably isn't interesting to users of the web UI. I think if it's not in the set of "real" ecosystems it should hidden or displayed as "unknown". Probably just hidden.

I think it's fine for it to be part of the API's JSON response (and I think it is) so you can still look at it.

@Zlopez
Copy link
Contributor

Zlopez commented Jan 10, 2019

Ok, I will hide it for users. But I will still let it visible for admins to resolve duplicates more easily.

@Zlopez Zlopez added Low Priority This ticket has a low priority and removed docs labels Jan 10, 2019
@abitrolly
Copy link
Contributor Author

abitrolly commented Jan 15, 2019 via email

@Zlopez
Copy link
Contributor

Zlopez commented Jan 15, 2019

As I said before, I will show it only to admins, because it will be easier to resolve duplicate project. Ecosystem is used in Anitya to make project unique for example in PyPi, because there should be only one project in PyPi with this name.

@Zlopez Zlopez added this to the 0.16.0 milestone Feb 21, 2019
@Zlopez Zlopez self-assigned this May 21, 2019
@Zlopez Zlopez modified the milestones: 0.16.0, 0.17.0 Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low Priority This ticket has a low priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants