Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures during project addition causes distro mapping to be skipped #735

Closed
QuLogic opened this issue Feb 16, 2019 · 1 comment · Fixed by #786
Closed

Failures during project addition causes distro mapping to be skipped #735

QuLogic opened this issue Feb 16, 2019 · 1 comment · Fixed by #786
Assignees
Labels
Milestone

Comments

@QuLogic
Copy link
Contributor

QuLogic commented Feb 16, 2019

If you add a new project and also supply a distro mapping, a version check is performed before adding the mapping. If this version check fails, the distro mapping is not applied.

For example, I just added cppzmq and it failed to check the version because GitHub rate-limited you. The Fedora distro mapping was then never added. I have since added it manually.

Also, the error message is reported on the "Add project" page making it seem like the project was never added, but it was.

@Zlopez Zlopez added this to the 0.16.0 milestone Feb 21, 2019
@Zlopez
Copy link
Contributor

Zlopez commented Apr 30, 2019

Implementation details

Mapping should be saved to the database before doing first check.

Addition of new project could be found here - https://github.com/release-monitoring/anitya/blob/master/anitya/ui.py#L447

This needs change in create_project function https://github.com/release-monitoring/anitya/blob/master/anitya/lib/utilities.py#L286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants