fix: array out of bounds (#648)

dirkmc · web-flow · commit 5e912de9fa61 · 2022-07-09T07:07:43.000+02:00
diff --git a/storagemarket/helper.go b/storagemarket/helper.go
@@ -169,7 +169,7 @@ func (c *ChainDealManager) dealIDFromPublishDealsMsg(ctx context.Context, tok ct
 	if outIdx >= len(dealIDs) {
 		return dealID, ctypes.EmptyTSK, fmt.Errorf("invalid publish storage deals ret marking %d as valid while only returning %d valid deals in publish deal message %s", outIdx, len(dealIDs), publishCid)
 	}
-	return dealIDs[dealIdx], wmsg.TipSet, nil
+	return dealIDs[outIdx], wmsg.TipSet, nil
 }
 func (c *ChainDealManager) CheckDealEquality(ctx context.Context, tok ctypes.TipSetKey, p1, p2 market.DealProposal) (bool, error) {
 	p1ClientID, err := c.fullnodeApi.StateLookupID(ctx, p1.Client, tok)

Original file line number	Diff line number	Diff line change
`@@ -169,7 +169,7 @@ func (c *ChainDealManager) dealIDFromPublishDealsMsg(ctx context.Context, tok ct`
`169`	`169`	`if outIdx >= len(dealIDs) {`
`170`	`170`	`return dealID, ctypes.EmptyTSK, fmt.Errorf("invalid publish storage deals ret marking %d as valid while only returning %d valid deals in publish deal message %s", outIdx, len(dealIDs), publishCid)`
`171`	`171`	`}`
`172`		`- return dealIDs[dealIdx], wmsg.TipSet, nil`
	`172`	`+ return dealIDs[outIdx], wmsg.TipSet, nil`
`173`	`173`	`}`
`174`	`174`	`func (c *ChainDealManager) CheckDealEquality(ctx context.Context, tok ctypes.TipSetKey, p1, p2 market.DealProposal) (bool, error) {`
`175`	`175`	`p1ClientID, err := c.fullnodeApi.StateLookupID(ctx, p1.Client, tok)`