Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal errors cause connection to close #7

Open
kmyokoyama opened this issue Mar 29, 2017 · 1 comment
Open

Fatal errors cause connection to close #7

kmyokoyama opened this issue Mar 29, 2017 · 1 comment

Comments

@kmyokoyama
Copy link

Hi,

Is it strictly necessary to close the connection with FreeSWITCH when a fatal error occurs in readOne function (thus returning false to readLoop)?

What are the implications of just ignoring it and keeping the connection open?

Thank you.

@fiorix
Copy link
Owner

fiorix commented Mar 31, 2017

It's been a while, but a quick glance tells me most of those errors are related to misbehavior like failing to conform to the protocol or broken pipes. It's probably safer to close the connection at that point.

If you're observing a specific type of error that you believe is non-fatal, I'd be happy to review any diffs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants