Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.4 build error #4475

Open
mmcgee-jump opened this issue Mar 11, 2025 · 1 comment
Open

v0.4 build error #4475

mmcgee-jump opened this issue Mar 11, 2025 · 1 comment

Comments

@mmcgee-jump
Copy link
Contributor

User reported. Figure out what compiler fails this, and add it to CI also.

src/choreo/forks/fd_forks.c: In function 'slot_ctx_restore':
src/choreo/forks/fd_forks.c:240:5: error: 'err' undeclared (first use in this function); did you mean 'erf'?
240 | err = fd_slot_bank_decode_footprint( &decode_ctx, &total_sz );
| ^~~
| erf
src/choreo/forks/fd_forks.c:240:5: note: each undeclared identifier is reported only once for each function it appears in
make: *** [config/everything.mk:311: build/native/gcc/obj/choreo/forks/fd_forks.o] Error 1

@lidatong
Copy link
Member

is this being caused by the same commit as the disco issue you alrady discussed with @ibhatt-jumptrading? 332bf47#diff-6bb379903f36e4fb7b5355954c93a11fce649e00e42c73b0ecf2044336fdcf25

looks like user is just compiling all libs (vs. just frankendancer) so dont think its a compiler issue

seems like it's a cherry pick issue that's missing another commit that declared int err earlier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants