chore(notifier+fetcher+signer+rpc): use spawn macro for non-crucial tasks

Author: matthias-wright

core/fetcher/src/fetcher.rs

@@ -44,9 +44,12 @@ impl<C: Collection> Fetcher<C> {
             resolver.clone(),
         );
 
-        tokio::spawn(async move {
-            waiter.run_until_shutdown(origin_fetcher.start()).await;
-        });
+        spawn!(
+            async move {
+                waiter.run_until_shutdown(origin_fetcher.start()).await;
+            },
+            "FETCHER: shutdown waiter"
+        );
 
         let worker = FetcherWorker::<C> {
             origin_tx,

core/notifier/src/lib.rs

@@ -78,12 +78,10 @@ impl<C: Collection> NotifierInterface<C> for Notifier<C> {
             self.notify.epoch_changed.subscribe(),
             self.waiter.wait_for_shutdown_owned(),
         );
-        tokio::spawn(before_epoch_change(
-            sender,
-            self.query_runner.clone(),
-            duration,
-            epoch_changed,
-        ));
+        spawn!(
+            before_epoch_change(sender, self.query_runner.clone(), duration, epoch_changed,),
+            "NOTIFIER: subscribe before epoch change"
+        );
         BroadcastSub(rx, self.waiter.wait_for_shutdown_owned())
     }
 }

core/rpc/src/event.rs

@@ -1,3 +1,4 @@
+use lightning_interfaces::spawn;
 use lightning_interfaces::types::Event;
 use tokio::sync::{broadcast, mpsc};
 
@@ -19,10 +20,13 @@ impl EventDistributor {
             broadcast_tx: broadcast_tx.clone(),
         };
 
-        tokio::spawn(async move {
-            Self::forward(&mut event_rx, &broadcast_tx).await;
-            tracing::info!("consensous dropped the tx");
-        });
+        spawn!(
+            async move {
+                Self::forward(&mut event_rx, &broadcast_tx).await;
+                tracing::info!("consensous dropped the tx");
+            },
+            "RPC: forward"
+        );
 
         this
     }

core/signer/src/lib.rs

@@ -104,9 +104,12 @@ impl<C: Collection> Signer<C> {
         guard.init_state(chain_id, nonce, secondary_nonce);
         drop(guard);
 
-        tokio::spawn(async move {
-            new_block_task(node_index, worker, subscriber, query_runner).await;
-        });
+        spawn!(
+            async move {
+                new_block_task(node_index, worker, subscriber, query_runner).await;
+            },
+            "SIGNER: new block task"
+        );
     }
 }