Skip to content

Commit a898df4

Browse files
committed
Auto merge of rust-lang#6470 - xFrednet:0000-rename-good-first-issue-in-docs, r=flip1995
Renamed the good first issue label in CONTRIBUTING.md Follow up from rust-lang#6468 Grep found some more references to the old `good first issue`. [CONTRIBUTING.md rendered](https://github.com/xFrednet/rust-clippy/blob/0000-rename-good-first-issue-in-docs/CONTRIBUTING.md) <details> <summary>grep output</summary> ``` $ grep -Ri "good first issue" rust-clippy/ rust-clippy/.git/COMMIT_EDITMSG:Renamed the good first issue label in CONTRIBUTING.md rust-clippy/.git/logs/HEAD:896d82f7ff64644656bda7a4ed8bbd55ca3b7619 1f58c2b xFrednet <[email protected]> 1608326295 +0000 commit: Renamed the good first issue label for rustbot rust-clippy/.git/logs/HEAD:9be704584f05e5a6c3ba2708590f98c1f261d19a ced54f2 xFrednet <[email protected]> 1608329602 +0000 commit: Renamed the good first issue label in CONTRIBUTING.md rust-clippy/.git/logs/refs/heads/0000-rename-good-first-issue-in-docs:896d82f7ff64644656bda7a4ed8bbd55ca3b7619 1f58c2b xFrednet <[email protected]> 1608326295 +0000 commit: Renamed the good first issue label for rustbot rust-clippy/.git/logs/refs/heads/0000-rename-good-first-issue-in-docs:9be704584f05e5a6c3ba2708590f98c1f261d19a ced54f2 xFrednet <[email protected]> 1608329602 +0000 commit: Renamed the good first issue label in CONTRIBUTING.md rust-clippy/CONTRIBUTING.md:Some issues are easier than others. The [`good first issue`] label can be used to find the easy issues. rust-clippy/CONTRIBUTING.md:[`E-medium`] issues are generally pretty easy too, though it's recommended you work on an [`good first issue`] rust-clippy/CONTRIBUTING.md:[`good first issue`]: https://github.com/rust-lang/rust-clippy/labels/good%20first%20issue ``` </details> --- changelog: None r? `@flip1995`
2 parents 9be7045 + ced54f2 commit a898df4

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

CONTRIBUTING.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ first read the [Basics docs](doc/basics.md).**
4949
All issues on Clippy are mentored, if you want help with a bug just ask
5050
@Manishearth, @flip1995, @phansch or @yaahc.
5151

52-
Some issues are easier than others. The [`good first issue`] label can be used to find the easy issues.
52+
Some issues are easier than others. The [`good-first-issue`] label can be used to find the easy issues.
5353
If you want to work on an issue, please leave a comment so that we can assign it to you!
5454

5555
There are also some abandoned PRs, marked with [`S-inactive-closed`].
@@ -68,7 +68,7 @@ To figure out how this syntax structure is encoded in the AST, it is recommended
6868
Usually the lint will end up to be a nested series of matches and ifs, [like so][deep-nesting].
6969
But we can make it nest-less by using [if_chain] macro, [like this][nest-less].
7070

71-
[`E-medium`] issues are generally pretty easy too, though it's recommended you work on an [`good first issue`]
71+
[`E-medium`] issues are generally pretty easy too, though it's recommended you work on an [`good-first-issue`]
7272
first. Sometimes they are only somewhat involved code wise, but not difficult per-se.
7373
Note that [`E-medium`] issues may require some knowledge of Clippy internals or some
7474
debugging to find the actual problem behind the issue.
@@ -77,7 +77,7 @@ debugging to find the actual problem behind the issue.
7777
lot of methods that are useful, though one of the most useful would be `expr_ty` (gives the type of
7878
an AST expression). `match_def_path()` in Clippy's `utils` module can also be useful.
7979

80-
[`good first issue`]: https://github.com/rust-lang/rust-clippy/labels/good%20first%20issue
80+
[`good-first-issue`]: https://github.com/rust-lang/rust-clippy/labels/good-first-issue
8181
[`S-inactive-closed`]: https://github.com/rust-lang/rust-clippy/pulls?q=is%3Aclosed+label%3AS-inactive-closed
8282
[`T-AST`]: https://github.com/rust-lang/rust-clippy/labels/T-AST
8383
[`T-middle`]: https://github.com/rust-lang/rust-clippy/labels/T-middle

0 commit comments

Comments
 (0)