Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work on markdown files? #150

Closed
ghost opened this issue Oct 31, 2022 · 3 comments · Fixed by #174
Closed

Does not work on markdown files? #150

ghost opened this issue Oct 31, 2022 · 3 comments · Fixed by #174

Comments

@ghost
Copy link

ghost commented Oct 31, 2022

I love this plugin so far and was about to implement something similar myself before I found it.
It just seems to not work on markdown files ?

@jose8a
Copy link

jose8a commented Nov 7, 2022

I'm seeing that all of the keywords that are supposed to be highlighted are all the same color even if I copy over and add the complete example configuration for "keywords" and "colors" from the plugin README. The different highlight colors work in fine in non-markdown files, and they even work in files without a file-extension.

@folke folke closed this as completed in f244aa3 Nov 8, 2022
@folke
Copy link
Owner

folke commented Nov 8, 2022

Todo comments was broken for non-treesitter files. So it only worked in markdown files if you had the markdown and markdown_inline treesitter parser istalled.

I just fixed it so it should also work in markdown files without treesitter.

Be aware, that by default highlighting will only work in comments. Check the config to change this. So for markdown, it will only highlight todo comments inside <!-- TODO: foooo -->

@jose8a
Copy link

jose8a commented Nov 8, 2022

Thanks @folke! I can see different highlights in the markdown files, though I have to play around with it some more to see if the colors match the config. But I get at least four different color highlights now (both in and out of a comment area).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants