Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

confirm() on disconnect can block other tabs #2398

Closed
fonsp opened this issue Nov 28, 2022 · 0 comments
Closed

confirm() on disconnect can block other tabs #2398

fonsp opened this issue Nov 28, 2022 · 0 comments
Labels
bug Something isn't working frontend Concerning the HTML editor

Comments

@fonsp
Copy link
Owner

fonsp commented Nov 28, 2022

I noticed that sometimes, localhost:1234 hangs when loading, until I close other localhost:1234 tabs that I had open in the background. I suspect that this happens when the other tabs show this confirm() message:

image

Some ideas:

  • Wait for the tab to come into focus before showing the confirm
  • Redirect without asking (might lose progress)
  • Make an HTML non-blocking confirm
@fonsp fonsp added the frontend Concerning the HTML editor label Nov 28, 2022
@fonsp fonsp added the bug Something isn't working label Jul 17, 2023
@fonsp fonsp closed this as completed in 3958cf5 Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working frontend Concerning the HTML editor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fonsp