Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot download notebook file from static html export #2728

Closed
fonsp opened this issue Nov 21, 2023 · 2 comments
Closed

Cannot download notebook file from static html export #2728

fonsp opened this issue Nov 21, 2023 · 2 comments

Comments

@fonsp
Copy link
Owner

fonsp commented Nov 21, 2023

Click Edit or Run, then download the notebook file:

https://j-fu.github.io/PlutoVista.jl/dev/plutovista.html

@fonsp
Copy link
Owner Author

fonsp commented Dec 6, 2023

It's because clicking the <a> is accidentally considered as a light dismiss of the <dialog>, triggering

e.preventDefault()

Notice that clicking anywhere on the dialog causes it to close :(

@fonsp fonsp closed this as completed in 7d3fd23 Dec 6, 2023
@fonsp
Copy link
Owner Author

fonsp commented Dec 6, 2023

Fixed it by removing the light_dismiss option on dialogs, I found it too tricky to implement correctly.

We won't be able to fix old Pluto exports unfortunately...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant