Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State management: update messages out-of-order #3009

Closed
fonsp opened this issue Aug 24, 2024 · 0 comments · Fixed by #3010
Closed

State management: update messages out-of-order #3009

fonsp opened this issue Aug 24, 2024 · 0 comments · Fixed by #3010
Labels
backend Concerning the julia server and runtime bug Something isn't working frontend Concerning the HTML editor HTTP/WS The connection between backend and frontend

Comments

@fonsp
Copy link
Owner

fonsp commented Aug 24, 2024 •
edited
Loading

I found a bug!

I was working on https://github.com/fonsp/PlutoImageCoordinatePicker.jl/blob/main/src/notebook.jl with two clients connected in parallel. In some cases, rapidly changing a bond would leave the client stuck in a cell.running = true state, while the other client kept working.

Calling pluto_get_message_log() in the devtools, I found that the client that got stuck had the last two :update_notebook messages reversed. You can see this because of counter.

image

Pluto 0.19.46
@fonsp fonsp added bug Something isn't working frontend Concerning the HTML editor backend Concerning the julia server and runtime HTTP/WS The connection between backend and frontend labels Aug 24, 2024
@fonsp fonsp mentioned this issue Aug 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend Concerning the julia server and runtime bug Something isn't working frontend Concerning the HTML editor HTTP/WS The connection between backend and frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix out of order state update messages fonsp/Pluto.jl
1 participant
@fonsp