-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving the error message when exceeding the ledger's withdrawal capacity #507
Comments
Does this only happen with Ledger? If so, should we limit the selection to be Max 20 if we know the account is from Ledger? |
@kwunyeung I confirm this happens when you delegate to more than the maximum amount of validators that the Ledger allows to withdraw with a single message, which is:
After reducing the delegations to from 21 to 20 validators, it works properly. I think that to limit the selection you would also need to know the Ledger device they are using (since the limits are different as written inside Forbole X as well). |
There is a device id on Ledger. It's being returned when the device is being connected. We should be able to identify it's an S or X from it. |
@kwunyeung Yes limiting the selection is a good choice in this case |
i found that the issue is not related to ledger withdraw limit, since it crashes on extension load instead of during tx signing. the issue is i am using the JSON string of tx data as query params in a web url, which exceeds the string length limit when you withdraw from > 20 validators. i will fix it by compressing the JSON string, otherwise the same will happen when you withdraw from >20 validators with recovery phrase |
After delegating to more than 20 validators, I tried to withdraw the rewards from all of them and the extension showed me a "connection refused from x.forbole.com" that, if inspected, was caused by a 520 server error.

I think it should be more explicit telling users why they're receiving that error.
The text was updated successfully, but these errors were encountered: