Withdraw commission even there is no delegation rewards

[kwunyeung]

For a particular case, if the validator is setting 100% commission, the account has 0 reward but only commission, Withdraw Rewards would not allow it to continue as it only check if there is delegation rewards.

X should allow validator account to withdraw commission even there is no delegation rewards.

[kwunyeung]

Got these errors when withdrawing commission from Ledger on staging.

[calvinkei]

@kwunyeung when did it happen? is it after the extension popup? did the extension UI show anything or crash immediately?

[kwunyeung]

@calvinkei after the extension popped up. The errors are from the extension.

[calvinkei]

@kwunyeung can i have your validator address?

[kwunyeung]

desmosvaloper17lca9smrdlwkznr92hypzrgsjkelnxeaacgrwq

[calvinkei]

@kwunyeung fixed in v0.18.1 staging

[kwunyeung]

The commission withdrawal is broadcasting a wrong message. It's now the same as withdraw rewards which is /cosmos.distribution.v1beta1.MsgWithdrawDelegatorReward. The correct message should be /cosmos.distribution.v1beta1.MsgWithdrawValidatorCommission. The message is as simple as

 {
        "@type": "/cosmos.distribution.v1beta1.MsgWithdrawValidatorCommission",
        "validator_address": "desmosvaloper17lca9smrdlwkznr92hypzrgsjkelnxeaacgrwq"
 }

We can sign the both messages for a validator and it will withdraw both rewards and commission from the validator.

[calvinkei]

@kwunyeung fixed and deployed on staging v0.18.2

but now it will withdraw rewards on the rewards tab, and withdraw commissions on the commissions tab. do you mean you want to broadcast both messages at the same time, no matter which tab they are at?

[kwunyeung]

@calvinkei Yes I would like to withdraw both in a single transaction for validators. Should we make it not in two tabs but show "Rewawrds and Commission" if the account is a validator? We can close this issue first and handle it in another issue if that make sense.

[calvinkei]

@kwunyeung this involves changes in UI. should we release it in this version and improve the UI later?

[kwunyeung]

All working good in production.