Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for snforge_std version doesn't work correctly with semver compatible versions #3081

Open
cptartur opened this issue Mar 12, 2025 · 0 comments
Labels
bug Something isn't working new snforge

Comments

@cptartur
Copy link
Member

Current State

In runtime, we check if snforge_std version matches that of snforge installation.
Since Scarb 2.10.0 and later support proper version resolving, it will install the latest patch version of the snforge_std that possibly can not match snforge version.

E.g. dependency is set to 0.38.0 but 0.38.3 is installed

This version should be compatible but we show an warning about incompatibility

Objective

Fix the check for snforge_std version

Additional Context

Semver compatible versions should be treated as correct and no version warning should be displayed

@cptartur cptartur added bug Something isn't working snforge labels Mar 12, 2025
@cptartur cptartur moved this to New in Starknet foundry Mar 12, 2025
@github-actions github-actions bot added the new label Mar 12, 2025
@cptartur cptartur moved this from New to Backlog in Starknet foundry Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working new snforge
Projects
Status: Backlog
Development

No branches or pull requests

1 participant