Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort cases with "last created to first created" on initial load. #298

Merged
merged 5 commits into from
Dec 2, 2020

Conversation

diraven
Copy link
Contributor

@diraven diraven commented Dec 2, 2020

No description provided.

@UncleClapton UncleClapton added the Type | Bug 🐛 An issue or PR that describes or fixes a problem with existing code label Dec 2, 2020
@UncleClapton
Copy link
Member

Hey there. Could you add the change to our changelog?

CHANGELOG.md Outdated
@@ -17,7 +17,7 @@ For detailed rules of this file, see [Changelog Rules](#changelog-rules)


### 🐛 Fixed
*
* Change cases sorting to "last created first" on initial dispatch board load.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to be adding this to CONTRIBUTING.md so there's no confusion going forward, but changes should link back to the PR that introduced them.

In this case you need to add the PR# like this:

* Change cases sorting to "last created first" on initial dispatch board load. - [#298][]

Then in the section between the unreleased changes and the previous release there are link definitions. It's here that you'll want to add:

[#298]: https://github.com/fuelrats/fuelrats.com/pull/297

Copy link
Contributor Author

@diraven diraven Dec 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious - why not regular md links like [link to Google!](http://google.com)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are often cases where there are multiple entries for a single PR. In that case it's better to just define the link once for cleanliness. To be consistent with those cases, we always just define links like this.

Copy link
Member

@UncleClapton UncleClapton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@UncleClapton
Copy link
Member

@all-contributors please add @diraven for code

@allcontributors
Copy link
Contributor

@UncleClapton

I've put up a pull request to add @diraven! 🎉

@UncleClapton UncleClapton merged commit 7ddba84 into FuelRats:develop Dec 2, 2020
@UncleClapton UncleClapton mentioned this pull request Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type | Bug 🐛 An issue or PR that describes or fixes a problem with existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants