-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort cases with "last created to first created" on initial load. #298
Conversation
Hey there. Could you add the change to our changelog? |
6ffeb47
to
7adb1f2
Compare
CHANGELOG.md
Outdated
@@ -17,7 +17,7 @@ For detailed rules of this file, see [Changelog Rules](#changelog-rules) | |||
|
|||
|
|||
### 🐛 Fixed | |||
* | |||
* Change cases sorting to "last created first" on initial dispatch board load. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to be adding this to CONTRIBUTING.md
so there's no confusion going forward, but changes should link back to the PR that introduced them.
In this case you need to add the PR# like this:
* Change cases sorting to "last created first" on initial dispatch board load. - [#298][]
Then in the section between the unreleased changes and the previous release there are link definitions. It's here that you'll want to add:
[#298]: https://github.com/fuelrats/fuelrats.com/pull/297
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious - why not regular md links like [link to Google!](http://google.com)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are often cases where there are multiple entries for a single PR. In that case it's better to just define the link once for cleanliness. To be consistent with those cases, we always just define links like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@all-contributors please add @diraven for code |
I've put up a pull request to add @diraven! 🎉 |
No description provided.