Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest node's Path property should be node's full path instead of it's directory path #344

Open
Kostov6 opened this issue Aug 26, 2024 · 1 comment
Labels
kind/bug Bug priority/3 Priority (lower number equals higher priority)

Comments

@Kostov6
Copy link
Contributor

Kostov6 commented Aug 26, 2024

What happened:

switch parent.Type {
case "dir":
node.Path = path.Join(parent.Path, parent.Dir)
case "manifest":
node.Path = parent.Path
default:
return fmt.Errorf("parent node \n\n%s\n is not a dir or manifest", node)
}
return nil

What you expected to happen:
node.Path to include node.Name

In other words

func (n *Node) NodePath() string {
return path.Join(n.Path, n.Name())
}

to become

func (n *Node) NodePath() string {
	return n.Path
}

How to categorize this issue?

/kind bug
/priority 3

@Kostov6 Kostov6 added the kind/bug Bug label Aug 26, 2024
@gardener-robot gardener-robot added the priority/3 Priority (lower number equals higher priority) label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Bug priority/3 Priority (lower number equals higher priority)
Projects
None yet
Development

No branches or pull requests

3 participants
@Kostov6 @gardener-robot and others