Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose internal and plugin metrics via /metrics endpoint #123

Closed
4 of 5 tasks
Tracked by #57
mostafa opened this issue Jan 17, 2023 · 0 comments · Fixed by #125
Closed
4 of 5 tasks
Tracked by #57

Expose internal and plugin metrics via /metrics endpoint #123

mostafa opened this issue Jan 17, 2023 · 0 comments · Fixed by #125
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mostafa
Copy link
Member

mostafa commented Jan 17, 2023

Plugins can independently expose Prometheus or other types of metrics that can be scraped or sent completely separately from GatewayD, however, it would be nice to have a feature to aggregate all Prometheus metrics in GatewayD, and then expose them on /metrics all at once.

This is my proposal:

  • Each plugin creates and exposes their own Prometheus metrics on the /metrics HTTP endpoint on a Unix/TCP socket.

  • The configuration will be passed to GatewayD as part of their configs.

  • While loading the plugin on startup, GatewayD will register the Unix socket's address or TCP port.

  • The merged and relabeled metrics from plugins, along with the ones from GatewayD, will be collected and exposed on the HTTP /metrics endpoints and served on TCP in GatewayD.

  • Metrics export gatewayd-plugin-sdk#2

@mostafa mostafa mentioned this issue Jan 17, 2023
2 tasks
@mostafa mostafa self-assigned this Jan 17, 2023
@mostafa mostafa added the enhancement New feature or request label Jan 17, 2023
@mostafa mostafa moved this from 🆕 New to 🏗 In progress in GatewayD Core Public Roadmap Jan 17, 2023
@mostafa mostafa added this to the v0.3.x milestone Jan 17, 2023
@mostafa mostafa moved this from 🏗 In progress to 👀 In review in GatewayD Core Public Roadmap Jan 20, 2023
@mostafa mostafa moved this from 👀 In review to ✅ Done in GatewayD Core Public Roadmap Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

1 participant