Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Darcy flow advection method #4748

Open
3 of 4 tasks
jdannberg opened this issue May 22, 2022 · 2 comments
Open
3 of 4 tasks

Fixes for Darcy flow advection method #4748

jdannberg opened this issue May 22, 2022 · 2 comments

Comments

@jdannberg
Copy link
Contributor

jdannberg commented May 22, 2022

There are a number of features that should be added to make the new Darcy flow method work correctly with a number of different tptions:

  • Add a section in the manual that explains the equations, why this is useful, and what the limitations are.
  • Adapt the time step according to the Darcy velocity (source/time_stepping/convection_time_step.cc)
  • Make sure we take this velocity into account when setting boundary conditions (function replace_outflow_boundary_ids in helper_functions.cc)
  • would a graphical output of u_f be useful?
@danieldouglas92
Copy link
Contributor

Manual section added in PR #4769

@danieldouglas92
Copy link
Contributor

@jdannberg points 2 and 4 have been addressed! I'll work on point 3 at some point soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants