Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default startup arguments so that it will work with the dev setup #203

Closed
holzeis opened this issue Mar 3, 2023 · 2 comments · Fixed by #209
Closed

Default startup arguments so that it will work with the dev setup #203

holzeis opened this issue Mar 3, 2023 · 2 comments · Fixed by #209
Assignees

Comments

@holzeis
Copy link
Contributor

holzeis commented Mar 3, 2023

The startup could / should be improved to not require any input for the dev environment. This could be done in the two possible ways.

  1. Enhance justfile to derive local ip and add the argument automatically
  2. Bind the docker-compose network to the host network so that lnd is able to find the coordinator on localhost.

Originally posted by @holzeis in #201 (comment)

@holzeis
Copy link
Contributor Author

holzeis commented Mar 6, 2023

As option 3, I investigated the to make use of host.docker.internal which gets resolved to the hosts localhost instead of the container localhost.

https://docs.docker.com/desktop/networking/#i-want-to-connect-from-a-container-to-a-service-on-the-host

However, there are several disadvantage to this option.

  1. Only works for mac and windows.
  2. lnd does support DNS hostnames in node announcements (BOLT 7) - discovery+lnwire: add support for DNS host names in NodeAnnouncement msg lightningnetwork/lnd#6337

@holzeis
Copy link
Contributor Author

holzeis commented Mar 6, 2023

Option 4, we could let the coordinator listen to 0.0.0.0 and add a cli flag to announce the node additionally on the local ip address. Note, announcing the node on 0.0.0.0 will not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant