Skip to content
This repository was archived by the owner on Sep 12, 2023. It is now read-only.

CI test run times can be really long #2473

Closed
da-kami opened this issue Jul 19, 2022 · 4 comments · Fixed by #2486
Closed

CI test run times can be really long #2473

da-kami opened this issue Jul 19, 2022 · 4 comments · Fixed by #2486

Comments

@da-kami
Copy link
Contributor

da-kami commented Jul 19, 2022

We had a CI macos test run that took 15 minutes to complete!
I don't think it is expected that CI takes that long.

See: https://github.com/itchysats/itchysats/runs/7407394638?check_suite_focus=true on #2469

@klochowicz
Copy link
Contributor

it is really long? I'm not sure it's worth reporting - we all know that unless we run actor tests in debug they will take long due to the contract setup taking a lot of time in all cases. There was an idea to store an opened Cfd in DB so that we can start almost all tests from "open" state, but we never actioned that due to other priorities.
If we care about the CI test time, we might to give this idea a spin :)

Also: I see that in the linked run macOS run took 17m, whilst ubuntu took 16m - is that additional minute worth singling out macos?

@bonomat bonomat changed the title macos CI test run times can be really long CI test run times can be really long Jul 19, 2022
@bonomat
Copy link
Collaborator

bonomat commented Jul 19, 2022

You are both right, all tests are now significantly slower.

This run here was relatively fast: https://github.com/itchysats/itchysats/actions/runs/2688891218

  • ubuntu: 9m
  • macos: 7m

and the one afterwards was slow: https://github.com/itchysats/itchysats/actions/runs/2689104767

  • ubuntu: 16m
  • macos: 21m

ever since the tests run for >15m

It looks like ever since this landed we slowed down: #2404

Actions-·-itchysats-itchysats

@bonomat
Copy link
Collaborator

bonomat commented Jul 19, 2022

cc @Restioson

@Restioson
Copy link
Collaborator

I'll try disable some more stuff from the macro's generated code itself when the tracing env var is disabled. It could be the 1s sleep or flush that's taking long.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants