Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named collection unwanted changes #1201

Closed
buitermark opened this issue Aug 20, 2017 · 2 comments
Closed

Named collection unwanted changes #1201

buitermark opened this issue Aug 20, 2017 · 2 comments
Labels

Comments

@buitermark
Copy link

When a named asset was added through system.yaml like this:

uikit:

  • ‘system://assets/uikit/uikit.min.css’
  • ‘system://assets/uikit/uikit.min.js’
  • ‘system://assets/uikit/uikit-icons.min.js’

it's correctly presented as

  • uikit[0] system://assets/uikit/uikit.min.css
  • uikit[1] system://assets/uikit/uikit.min.js
  • uikit[2] system://assets/uikit/uikit-icons.min.js

but after only a save in the plugin it's left unusable as

uikit[0 system://assets/uikit/uikit.min.css
uikit[1 system://assets/uikit/uikit.min.js
uikit[2 system://assets/uikit/uikit-icons.min.js

So the closing brackets are removed, and leave it unusable after that.

Mentioned this here:
https://discourse.getgrav.org/t/asset-collections-in-system-yaml-bug/4377

@rhukster rhukster added the bug label Aug 22, 2017
@rhukster
Copy link
Member

Confirmed, this needs to be updated to support an arbitrary list of assets per name, not just a single one. We have a field that should be able to handle this, but i'm not sure it's quite ready for primetime. I will do some testing.

@rhukster
Copy link
Member

Ok multilevel seems to work ok.. See this commit for an easy fix on your side.

getgrav/grav@04690ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants