Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the SameSite cookie flag #2173

Closed
ArnCo opened this issue Sep 7, 2018 · 7 comments
Closed

Add the SameSite cookie flag #2173

ArnCo opened this issue Sep 7, 2018 · 7 comments

Comments

@ArnCo
Copy link

ArnCo commented Sep 7, 2018

Hey guys,

I see that HttpOnly and Secure flags are configurable in the configuration section.
Would it be possible to add a switch for the SameSite cookie flag ?

Thanks a lot and keep up the great work,

ArnCo

@hughbris
Copy link
Contributor

hughbris commented Sep 9, 2018

Could you please explain this or link to something that does?

@ArnCo
Copy link
Author

ArnCo commented Sep 12, 2018

Hey @hughbris ,

Here is an explanation of what it does :
https://www.sjoerdlangkemper.nl/2016/04/14/preventing-csrf-with-samesite-cookie-attribute/
Basically, this is an additional protection against CSRF.

Cheers,
ArnCo

@youngpabl0
Copy link

image
Guyz, hello, i too dont search any option to set this Cookie, may be you have any advices? Thanx.

@ArnCo
Copy link
Author

ArnCo commented Dec 12, 2019

Hi @lovkiymusic,

For now I'm doing it directly on my NginX server with the "proxy_cookie_path" directive.

Cheers,

ArnCo

@sebastianbaumann
Copy link

sebastianbaumann commented Aug 27, 2020

+1

would be great if we could set the samesite attribute for cookies in the system.yaml like the others attribute. example:

session:
enabled: true
initialize: true
timeout: 1800
name: site-
uniqueness: path
secure: true
httponly: true
split: true
path: null
samesite: true

@randoum
Copy link
Contributor

randoum commented Nov 11, 2020

See #3063

@ArnCo
Copy link
Author

ArnCo commented Nov 19, 2020

Looks like this can be closed, given the previous comment. Cheers 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants