Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting over 3000 saved forms that all fail won't show notification #6628

Open
seadowg opened this issue Feb 28, 2025 · 0 comments
Open

Comments

@seadowg
Copy link
Member

seadowg commented Feb 28, 2025

ODK Collect version

v2025.1.0

Android version

All

Problem description

Submitting a lot of forms will cause a crash if they all fail, the error notification won't show because creating the notification causes a background (non-fatal) exception. This happens because the amount of data being included in the notification to be passed on from "Show details" is too large.

There's a crash report demonstrating this here. The number of failures it takes to reproduce was worked out using automated tests.

Steps to reproduce the problem

  1. Fill out and finalize 3000+ forms (with auto-send disabled)
  2. Change the server URL in project settings to something incorrect
  3. Enable auto send and finalize (to trigger auto-send)

Expected behavior

The notification should be shown, but it will require rework in some way. There are a few options:

  • Show a warning that there are too many errors after clicking "Show details"
  • Trim the number of errors to avoid the exception
  • Rework how errors get passed to ErrorActivity to avoid the problem entirely
@seadowg seadowg moved this from inbox to later in ODK Collect Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: later
Development

No branches or pull requests

1 participant