Skip to content

Commit bf69cfe

Browse files
authored
vulkan: fix bug in coopmat1 mul_mat_id (#12316)
* tests: run mul_mat_id with a larger N * vulkan: fix bug in coopmat1 mul_mat_id
1 parent 10f2e81 commit bf69cfe

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

ggml/src/ggml-vulkan/vulkan-shaders/mul_mm.comp

+1-1
Original file line numberDiff line numberDiff line change
@@ -777,7 +777,7 @@ void main() {
777777
[[unroll]] for (uint cm_col = 0; cm_col < cms_per_col; cm_col++) {
778778
coopMatStore(sums[cm_col * cms_per_row + cm_row], coopmat_stage, warp_i * TM * TN, TM, gl_CooperativeMatrixLayoutColumnMajor);
779779

780-
[[unroll]] for (uint col = 0; col < BN; col += storestride) {
780+
[[unroll]] for (uint col = 0; col < TN; col += storestride) {
781781
const uint row_i = dc + cm_col * TN + col + store_c;
782782
if (row_i >= _ne1) break;
783783

tests/test-backend-ops.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -4113,7 +4113,7 @@ static std::vector<std::unique_ptr<test_case>> make_test_cases_eval() {
41134113
for (int n_mats : {4, 8}) {
41144114
for (int n_used : {1, 2, 4}) {
41154115
for (bool b : {false, true}) {
4116-
for (int n : {1, 32}) {
4116+
for (int n : {1, 32, 129}) {
41174117
int m = 512;
41184118
int k = 256;
41194119
test_cases.emplace_back(new test_mul_mat_id(type_a, type_b, n_mats, n_used, b, m, n, k));

0 commit comments

Comments
 (0)