New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional absolute threshold #30

Open

chevdor opened this issue Oct 21, 2022 · 0 comments

Contributor

chevdor commented Oct 21, 2022

Currently, we can set a threashold in %. Let's consider some examples using time below.

Say we have 2 changes:

Pallet A / Call C1: 100ms -> 200ms <== Here is the big change
Pallet A / Call C2: 100ms -> 105ms
The current % change threshold allows focusing on the big change.

If we consider however:

Pallet A / Call C1: 1µs -> 2µs
Pallet A / Call C2: 100ms -> 105ms <== Here is the big change

We see that the interesing changes are no longer the big %.

We could address that will a new threshold (in addition to the existing) and allow filtering out all calls under 10µs for instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment