Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart punctuation and hardbreaks don't mix in render_doc #17

Closed
deep-spaced opened this issue Oct 13, 2015 · 3 comments · Fixed by #18
Closed

Smart punctuation and hardbreaks don't mix in render_doc #17

deep-spaced opened this issue Oct 13, 2015 · 3 comments · Fixed by #18

Comments

@deep-spaced
Copy link
Contributor

Hello!

I'm working on a project and we liked the idea of mixing smart punctuation and hardbreaks using a custom renderer. When I did so, however, commonmarker failed to render the hardbreaks. I've set up a failing test here:

https://github.com/GimliLongBow/commonmarker/commit/8e5a08fde1dbdaa656346f1eb49aeda2cd5a372f

Looks like the straight render_html call works fine and render_doc doesn't. I'd love to try to figure this out, but I'm not sure if the problem is in the Ruby wrapper or the C library. Can you point me in the right direction?

Thanks!

@gjtorikian
Copy link
Owner

Hi there! If you want to take a look at providing a fix, the problem is almost certainly on the Ruby side, around this line, where options are combined before being handed off to C. Otherwise I can take a look in a few days or so.

@deep-spaced
Copy link
Contributor Author

Hmm. Poking around, it seems that the correct value (10) is being generated by the config line. After some more poking, render_html and render_doc both generate the wrong output; evidently one failing test in the file makes it ignore running the other test (that might be me). I'll keep doing some digging.

@deep-spaced
Copy link
Contributor Author

That's excellent! Thanks for digging in and fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants