Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SSH signing #17449

Closed
ptman opened this issue Oct 27, 2021 · 4 comments · Fixed by #17743
Closed

Add SSH signing #17449

ptman opened this issue Oct 27, 2021 · 4 comments · Fixed by #17743
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@ptman
Copy link
Contributor

ptman commented Oct 27, 2021

Feature Description

Like GPG signing, but with SSH keys

git/git#1041

Screenshots

No response
@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Oct 28, 2021
@unbeatable-101
Copy link

Git v2.34.0 is out now with support for this.

@melvincarvalho
Copy link

Yes, I'm using it. It's great. Here's what it looks like currently on github:

image

https://github.com/melvincarvalho/melvincarvalho.com/commits/gh-pages

git verify-commit also works

I've mailed github support about changing that from unverified -> verified ... hopefully soon!

@unbeatable-101
Copy link

unbeatable-101 commented Nov 16, 2021 •
edited
Loading

If you click on the unverified you can see it is recognized as signed, just GitHub doesn't know how to read it.

GitHub supports GPG and S/MIME signatures. We don’t know what type of signature this is.

See also: community/community#7744

@42wim
Copy link
Member

42wim commented Nov 20, 2021

I'm going to try and implement this.
Already created a library to create/verify those armored ssh signatures (https://github.com/42wim/sshsig)

@42wim 42wim mentioned this issue Nov 21, 2021
Merged
4 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for ssh commit signing 42wim/gitea
5 participants
@ptman @melvincarvalho @lunny @42wim @unbeatable-101