Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme.html #2254

Closed
bluemmb opened this issue Aug 4, 2017 · 9 comments
Closed

readme.html #2254

bluemmb opened this issue Aug 4, 2017 · 9 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@bluemmb
Copy link

bluemmb commented Aug 4, 2017

Hi.

How can I add this feature, that gitea loads "readme.html" as html file under "readme.md" file in repositories home page ?

@lunny
Copy link
Member

lunny commented Aug 4, 2017

I think that's not a good idea maybe.

@bluemmb
Copy link
Author

bluemmb commented Aug 4, 2017

I don't want to use it in public places or somewhere that can cause security issues or ...
These are the reasons I want to have this feature :

  1. Our language is written from Right to Left.
  2. My friends who using local gitea are not good in english and main thing for our repos are readme part.
  3. With html files we have many features that we haven't it with md files.

I would be grateful If you could help me.

@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Aug 4, 2017
@lunny
Copy link
Member

lunny commented Aug 4, 2017

Maybe a config default off and admin could turn it on.

@lunny lunny added this to the 1.x.x milestone Aug 4, 2017
@sapk
Copy link
Member

sapk commented Aug 4, 2017

We could just add dir="auto" like gitlab https://gitlab.com/gitlab-org/gitlab-ce/issues/35#note_14966359

@sapk
Copy link
Member

sapk commented Aug 4, 2017

For more context, problem around that has been discuss on dear-github/dear-github#147 because github suffer the same problem.

@lunny
Copy link
Member

lunny commented Aug 4, 2017

@sapk we are different from Github. If user know what the dangerous, he can enable the feature himself.

@sapk
Copy link
Member

sapk commented Aug 4, 2017

Yes, I am not against. Just suggesting that if it's for RTL language there is maybe a better solution and that is has allready being discuss on other project.
As for displaying html file, some html syntax is allowed in markdown and for more complex I would suggest to use caddy with git plugin. I suggest that because it migth be enough fo the user.
On the other side, if needed we could easily implemnet/enable html file passtrough if admin allow it like you suggest.

@bkcsoft
Copy link
Member

bkcsoft commented Aug 8, 2017

Allowing readme.html to be rendered isn't that much of a problem, IF all JS & SVG is disabled/removed from that file before rendering.

@6543
Copy link
Member

6543 commented Sep 7, 2020

I thin it is possible to do with "custom markdown rendering", just add this to the config:

[markup.html]
ENABLED = true
FILE_EXTENSIONS = .html
RENDER_COMMAND = "cat"
IS_INPUT_FILE = false

@6543 6543 closed this as completed Sep 7, 2020
@lunny lunny removed this from the 1.x.x milestone Sep 8, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

5 participants