Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several versions of xorm included in go.sum #8019

Closed
guillep2k opened this issue Aug 28, 2019 · 3 comments · Fixed by #8020
Closed

Several versions of xorm included in go.sum #8019

guillep2k opened this issue Aug 28, 2019 · 3 comments · Fixed by #8020

Comments

@guillep2k
Copy link
Member

I don't know if this is a problem, but I've noticed several versions of xorm in go.sum:

gitea/go.sum

Lines 148 to 155 in 1338825

github.com/go-xorm/sqlfiddle v0.0.0-20180821085327-62ce714f951a h1:9wScpmSP5A3Bk8V3XHWUcJmYTh+ZnlHVyc+A4oZYS3Y=
github.com/go-xorm/sqlfiddle v0.0.0-20180821085327-62ce714f951a/go.mod h1:56xuuqnHyryaerycW3BfssRdxQstACi0Epw/yC5E2xM=
github.com/go-xorm/xorm v0.7.4 h1:g/NgC590SzqV5VKmdRDNe/K3Holw3YJUCXX28r+rFGw=
github.com/go-xorm/xorm v0.7.4/go.mod h1:vpza5fydeRgt+stvo9qgMhSNohYqmNt0I1/D6hkCekA=
github.com/go-xorm/xorm v0.7.7-0.20190822154023-17592d96b35b h1:Y0hWUheXDHpIs7BWtJcykO4d1VOsVDKg1PsP5YJwxxM=
github.com/go-xorm/xorm v0.7.7-0.20190822154023-17592d96b35b/go.mod h1:nqz2TAsuOHWH2yk4FYWtacCGgdbrcdZ5mF1XadqEHls=
github.com/gogits/chardet v0.0.0-20150115103509-2404f7772561 h1:deE7ritpK04PgtpyVOS2TYcQEld9qLCD5b5EbVNOuLA=
github.com/gogits/chardet v0.0.0-20150115103509-2404f7772561/go.mod h1:YgYOrVn3Nj9Tq0EvjmFbphRytDj7JNRoWSStJZWDJTQ=

Everything started when I wanted to reference this commit: Add insert select where in #7898.

I did that by editing go.mod like:

github.com/go-xorm/xorm master
xorm.io/core master

And then running make vendor.

There's been some discussion at the #maintainers chat about this, and it's been suggested that @lafriks updated github.com/lafriks/xormstore (which he did).

However, I couldn't figure out the right way to update go.mod, as I kept getting even more versions of go-xorm/xorm in my go.sum.

So I desisted of making any changes and report this here, so people with better understanding of this can solve it (if necessary) or simply ignore it.
@sapk
Copy link
Member

sapk commented Aug 28, 2019 

GO111MODULE=on go get -u -v github.com/lafriks/[email protected]
GO111MODULE=on go mod tidy
GO111MODULE=on go mod vendor
git add vendor

@sapk
Copy link
Member

sapk commented Aug 28, 2019 •
edited
Loading

Ho
I just see that xorm v0.7.7 is not released yet and the ref v0.7.7-0.20190822154023-17592d96b35b point to a commit and not a release.

@sapk
Copy link
Member

sapk commented Aug 28, 2019 •
edited
Loading

The new version in xormstore is v0.7.6 so we still have two version in use in the wait for a tag on xorm.
Updating xormstore should still be done to align other db drivers

@guillep2k guillep2k mentioned this issue Aug 28, 2019
Merged
@sapk sapk mentioned this issue Aug 28, 2019
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update github.com/lafriks/xormstore and tidy up mod.go guillep2k/gitea
2 participants
@sapk @guillep2k