-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GC job failed when the execution time exceed 24 hours #16587
Comments
This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days. |
move out of v2.6 per discuss with @stonezdj , since we have introduced failure tolerance and process present, this issue is not a high priority task for GC. And, there is no specific recommendation for the maximum duration, as it could be 3 days, 4 days, depending on the use of the storage. |
This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days. |
This issue was closed because it has been stalled for 30 days with no activity. If this issue is still relevant, please re-open a new issue. |
We may have to fork gocraft/worker to support configuration on the timeout. |
Because job service is based on gocraft/work framework, it will expire the job status every 24 hours, the job still keep running after it exceeds 24 hours but it is invisible in the job service dashboard. To avoid this issue, for example, you need to expand time from 24 hours to 168 Update the common/config/jobservice/env to add the following env
Update the common/config/jobservice/config.yml
Updated in https://github.com/goharbor/harbor/wiki/Harbor-FAQs |
fixed in #21390 |
GC job might take a long time(>24hours) to complete, the job service reaper will mark this job as failed when it exceeds 24 hours.
Current this setting is hardcode and result in the GC job in some env always failing.
harbor/src/jobservice/worker/cworker/reaper.go
Line 33 in 382e77b
The text was updated successfully, but these errors were encountered: