Skip to content

Commit 74a4918

Browse files
committed
cmd/go/testdata/script: disable build_plugin_reproducible on darwin
It's broken with the latest XCode versions, and is also already disabled on darwin builders. Disable the test to get go test cmd/go working on local builds again. For #64947 Change-Id: I5a4b46cf23cbe887df4903f90b54cd2225f51233 Reviewed-on: https://go-review.googlesource.com/c/go/+/584937 Reviewed-by: Dmitri Shuralyov <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
1 parent a0a6026 commit 74a4918

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

src/cmd/go/testdata/script/build_plugin_reproducible.txt

+4-6
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,10 @@
22
[short] skip
33
[!cgo] skip '-buildmode=plugin requires external linking'
44

5-
# This test has problems when run on the LUCI darwin longtest builder,
6-
# which uses a more contemporary Xcode version that is unfriendly to
7-
# reproducible builds (see issue #64947 for the gory details). Note
8-
# that individual developers running "go test cmd/go" on Darwin may
9-
# still run into failures depending on their Xcode version.
10-
[GOOS:darwin] [go-builder] skip
5+
# This test has problems when run on darwin, when using a more
6+
# contemporary Xcode version that is unfriendly to reproducible builds
7+
# (see issue #64947 for the gory details).
8+
[GOOS:darwin] skip
119

1210
go build -trimpath -buildvcs=false -buildmode=plugin -o a.so main.go
1311
go build -trimpath -buildvcs=false -buildmode=plugin -o b.so main.go

0 commit comments

Comments
 (0)