Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some internal http client call rely on methods that do not support context #769

Open
gdbranco opened this issue Feb 13, 2025 · 1 comment

Comments

@gdbranco
Copy link

What

Current implementation for oauth2 repo, specifically jwt, jira and google/downscope packages rely on .PostForm function which does not allow to specify a context.

Problem

Forwarding the context provides consumers more control over timeout/cancel, allows to leverage context values in log message wrappers etc

Proposal

The context is available within the function and preferably should be used to give more control to the consumer

@gdbranco
Copy link
Author

gdbranco commented Feb 13, 2025

I went ahead and setup a PR #770 covering the work for this refactor

Edit: I'm looking through the contributing guide to follow the proper flow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant