Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanly close reading thread #38

Closed
etam opened this issue Jul 14, 2020 · 0 comments · Fixed by #40
Closed

Cleanly close reading thread #38

etam opened this issue Jul 14, 2020 · 0 comments · Fixed by #40
Assignees

Comments

@etam
Copy link
Contributor

etam commented Jul 14, 2020

The reader thread spawned by GuestAgent is not closed on shutdown. Instead it panics after communications channels are closed.

Example solution: https://github.com/golemfactory/yagna/blob/d6015a7051361f283b1442dcb9679ab2ab200f26/exe-unit/runtime-api/src/server/client.rs#L184
See also: https://docs.rs/futures/0.3.5/futures/future/struct.Abortable.html
tokio-rs/tokio#1830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants