New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanly close reading thread #38

Closed

etam opened this issue Jul 14, 2020 · 0 comments · Fixed by #40

Assignees

Contributor

etam commented Jul 14, 2020

The reader thread spawned by GuestAgent is not closed on shutdown. Instead it panics after communications channels are closed.

Example solution: https://github.com/golemfactory/yagna/blob/d6015a7051361f283b1442dcb9679ab2ab200f26/exe-unit/runtime-api/src/server/client.rs#L184
See also: https://docs.rs/futures/0.3.5/futures/future/struct.Abortable.html
tokio-rs/tokio#1830

boryspoplawski mentioned this issue

Add proper handling of errors in reader task #40

Merged

boryspoplawski self-assigned this

boryspoplawski closed this as completed in #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment