Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish closure compiler to registry.bazel.build #4224

Open
christianscott opened this issue Feb 25, 2025 · 4 comments
Open

Publish closure compiler to registry.bazel.build #4224

christianscott opened this issue Feb 25, 2025 · 4 comments

Comments

@christianscott
Copy link

Hello, I'd love to be able to depend on closure compiler via bzlmod. I believe the only blocker preventing this module being published to bcr is the use of git_override() to depend on google_bazel_common. If google_bazel_common is on the bcr then we can remove the override and also publish closure compiler. I have opened an issue in that repo as well: google/bazel-common#213

@brad4d
Copy link
Contributor

brad4d commented Feb 25, 2025

Would you be able to send us a pull request with the change you're asking for?

We have no knowledge of registry.bazel.build.
If supporting it is as simple as a one-line change to one of our bazel build files, we're probably ok with doing that.

When creating the pull request, bear in mind that we don't actually know anything about this, and add comments appropriately.

@christianscott
Copy link
Author

christianscott commented Feb 26, 2025

hey Brad, certainly. I'll work on it once google/bazel-common has been published to the registry. I'm not totally sure what is involved in publishing, but I believe that we won't need to make any changes to this repo beyond removing the git_override(). To get it published to the registry itself, IIUC I'll just need to open a PR in https://github.com/bazelbuild/bazel-central-registry

@jzhan-canva
Copy link
Contributor

Created PR #4226 to replace git_override

@jzhan-canva
Copy link
Contributor

git_override has been removed from codebase, next step is to publish closure compiler to registry. I think this requires the repo owner to submit request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants