Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link is not extracted at v0.3.3 #202

Closed
dalance opened this issue Jun 10, 2024 · 4 comments · Fixed by #203 or rust-lang/rust-by-example#1863
Closed

Link is not extracted at v0.3.3 #202

dalance opened this issue Jun 10, 2024 · 4 comments · Fixed by #203 or rust-lang/rust-by-example#1863

Comments

@dalance
Copy link
Contributor

dalance commented Jun 10, 2024

I found an unexpected behaviour change.
At v0.3.3, link doesn't seem to be extracted.
The reproduce proredure is below:

#: src/index.md:3
msgid ""
"[Rust](https://www.rust-lang.org/) is a modern systems programming language "
"focusing on safety, speed, and concurrency. It accomplishes these goals by "
"being memory safe without using  garbage collection."
msgstr ""
  • get the following msgid at v0.3.3
#: src/index.md:3
msgid ""
"Rust is a modern systems programming language focusing on safety, speed, and "
"concurrency. It accomplishes these goals by being memory safe without using "
"garbage collection."
msgstr ""
@dalance
Copy link
Contributor Author

dalance commented Jun 10, 2024

#67 seems to cause the change.

97f4fb5 works fine.
ab7c48d is broken.

@dalance
Copy link
Contributor Author

dalance commented Jun 10, 2024

@mgeisler @kdarkhan
Could you check this issue and #203?
This seems to be critical because generated messages.pot becomes broken.

@kdarkhan
Copy link
Collaborator

Thanks for the fix @dalance, sorry missed the notification.

I merged and will try to release a new version once I get #204 approved.

@kdarkhan
Copy link
Collaborator

Just published version 0.3.4 to crates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants