Skip to content

Commit a0e67d9

Browse files
committed
Use Qt5 by default on all desktop builds
With this CL, Windows build start using Qt5 unless --qtver=4 is explicitly specified. BUG=#327 TEST= REF_BUG=26887740 REF_CL=136967529 REF_TIME=2016-10-23T10:48:40-07:00 REF_TIME_RAW=1477244920 -0700
1 parent 44a37f4 commit a0e67d9

File tree

4 files changed

+18
-18
lines changed

4 files changed

+18
-18
lines changed

appveyor.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,6 @@ install:
3838
- choco install ninja -version 1.7.1
3939
build_script:
4040
- cd src
41-
- python build_mozc.py gyp --qtdir=C:\Qt\5.6\msvc2015 --qtver=5
41+
- python build_mozc.py gyp --qtdir=C:\Qt\5.6\msvc2015
4242
- python build_mozc.py build -c Release package
4343
test: off

docs/build_mozc_in_windows.md

+15-8
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,9 @@ How to build Mozc in Windows
1010
Building Mozc on Windows requires the following software.
1111

1212
* [Visual Studio 2015 Community Edition](http://visualstudio.com/free), or any greater edition.
13-
* (optinal) [Qt libraries](http://download.qt.io/archive/qt/)
13+
* (optinal) [Qt 5](https://download.qt.io/official_releases/qt/)
1414
* Commercial version and LGPL version are available.
15+
* You must download msvs2015 32-bit version of Qt 5 since currently `mozc_tool.exe` needs to be built as a 32-bit executable.
1516

1617
# Get dependent prebuilt binaries
1718

@@ -44,10 +45,10 @@ First, you'll need to generate Visual C++ project files using a tool called [GYP
4445

4546
```
4647
cd c:\work\mozc\src
47-
python build_mozc.py gyp --qtdir=c:\Qt\4.8.0
48+
python build_mozc.py gyp --qtdir=c:\Qt\Qt5.6.2\5.6\msvc2015
4849
```
4950

50-
The directory of Qt (`C:\Qt\4.8.0` in this example) differs based on Qt version. If you specify `--noqt` option instead of `--qtdir=<dir to Qt>`, mozc\_tool will be built as a mock version, which does nothing.
51+
The directory of Qt (`c:\Qt\Qt5.6.2\5.6\msvc2015` in this example) differs based on Qt version. If you specify `--noqt` option instead of `--qtdir=<dir to Qt>`, mozc\_tool will be built as a mock version, which does nothing.
5152

5253
You can also specify `--branding=GoogleJapaneseInput` option and `--wix_dir=<dir to WiX binaries>` option here to reproduce official Google Japanese Input binaries and installers.
5354

@@ -94,10 +95,12 @@ Following files must be placed under %ProgramFiles%\Mozc.
9495
* `C:\work\mozc\src\out\Release\mozc_server.exe`
9596
* `C:\work\mozc\src\out\Release\mozc_tool.exe` (if you specified `--noqt` option)
9697
* `C:\work\mozc\src\out\ReleaseDynamic\mozc_tool.exe` (if you didn't specify `--noqt` option)
97-
* `C:\work\mozc\src\out\ReleaseDynamic\QtCore4.dll` (not required if you specified `--noqt` option)
98-
* `C:\work\mozc\src\out\ReleaseDynamic\QtGui4.dll` (not required if you specified `--noqt` option)
98+
* `C:\work\mozc\src\out\ReleaseDynamic\Qt5Core.dll` (not required if you specified `--noqt` option)
99+
* `C:\work\mozc\src\out\ReleaseDynamic\Qt5Gui.dll` (not required if you specified `--noqt` option)
100+
* `C:\work\mozc\src\out\ReleaseDynamic\Qt5Widgets.dll` (not required if you specified `--noqt` option)
101+
* `C:\work\mozc\src\out\ReleaseDynamic\platforms\qwindows.dll` (not required if you specified `--noqt` option)
99102

100-
`QtCore4.dll` and `QtGui4.dll` are not required if you specified `--noqt` option into the gyp command.
103+
`Qt5Core.dll`, `Qt5Gui.dll`, `Qt5Widgets.dll`, and `qwindows.dll` are not required if you specified `--noqt` option into the gyp command.
101104

102105
### Register Mozc for IMM32 into 32-bit environment
103106

@@ -165,10 +168,14 @@ Following files must be placed under %ProgramFiles(x86)%\Mozc.
165168
* `C:\work\mozc\src\out\Release\mozc_server.exe`
166169
* `C:\work\mozc\src\out\Release\mozc_tool.exe` (if you specified `--noqt` option)
167170
* `C:\work\mozc\src\out\ReleaseDynamic\mozc\_tool.exe` (if you didn't specify `--noqt` option)
168-
* `C:\work\mozc\src\out\ReleaseDynamic\QtCore4.dll` (not required if you specified `--noqt` option)
169-
* `C:\work\mozc\src\out\ReleaseDynamic\QtGui4.dll` (not required if you specified `--noqt` option)
171+
* `C:\work\mozc\src\out\ReleaseDynamic\Qt5Core.dll` (not required if you specified `--noqt` option)
172+
* `C:\work\mozc\src\out\ReleaseDynamic\Qt5Gui.dll` (not required if you specified `--noqt` option)
173+
* `C:\work\mozc\src\out\ReleaseDynamic\Qt5Widgets.dll` (not required if you specified `--noqt` option)
174+
* `C:\work\mozc\src\out\ReleaseDynamic\platforms\qwindows.dll` (not required if you specified `--noqt` option)
170175
* `C:\work\mozc\src\out\Release_x64\mozc_broker64.exe`
171176

177+
`Qt5Core.dll`, `Qt5Gui.dll`, `Qt5Widgets.dll`, and `qwindows.dll` are not required if you specified `--noqt` option into the gyp command.
178+
172179
### Register Mozc for IMM32 into 64-bit environment
173180

174181
Following files must be placed under `%windir%\System32`.

src/build_mozc.py

+1-8
Original file line numberDiff line numberDiff line change
@@ -272,14 +272,7 @@ def ParseGypOptions(args):
272272
parser.add_option('--gypdir', dest='gypdir',
273273
help='Specifies the location of GYP to be used.')
274274
parser.add_option('--noqt', action='store_true', dest='noqt', default=False)
275-
276-
default_qtver = '5'
277-
# TODO(yukawa): Support Qt5 on Windows
278-
if IsWindows():
279-
default_qtver = '4'
280-
parser.add_option('--qtver', dest='qtver', choices=('4', '5'),
281-
default=default_qtver)
282-
275+
parser.add_option('--qtver', dest='qtver', choices=('4', '5'), default='5')
283276
parser.add_option('--version_file', dest='version_file',
284277
help='use the specified version template file',
285278
default='data/version/mozc_version_template.bzl')

src/data/version/mozc_version_template.bzl

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030

3131
MAJOR=2
3232
MINOR=19
33-
BUILD=2648
33+
BUILD=2649
3434
REVISION=102
3535
# This version represents the version of Mozc IME engine (converter, predictor,
3636
# etc.). This version info is included both in the Mozc server and in the Mozc

0 commit comments

Comments
 (0)