Skip to content

Commit 40084f1

Browse files
committed
Remove padding to use passed widget padding and fix story inconsistencies.
1 parent c82f822 commit 40084f1

13 files changed

+15
-7
lines changed

assets/js/modules/adsense/components/widgets/ConnectAdSenseCTATileWidget.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export default function ConnectAdSenseCTATileWidget( { Widget, widgetSlug } ) {
3939
// this component and thus sharing the same state), it is wrapped with a `Widget` component - the net
4040
// result being the ConnectModuleCTATile is correctly wrapped in a `Widget` in both cases.
4141
return (
42-
<Widget noPadding>
42+
<Widget>
4343
<ConnectModuleCTATile { ...metadata } />
4444
</Widget>
4545
);

assets/js/modules/analytics-4/components/widgets/ConnectGA4CTATileWidget.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export default function ConnectGA4CTATileWidget( { Widget, widgetSlug } ) {
6262
// this component and thus sharing the same state), it is wrapped with a `Widget` component - the net
6363
// result being the ConnectModuleCTATile is correctly wrapped in a `Widget` in both cases.
6464
return (
65-
<Widget noPadding>
65+
<Widget>
6666
<ConnectModuleCTATile { ...metadata } />
6767
</Widget>
6868
);

assets/sass/components/key-metrics/_googlesitekit-km-connect-module-cta-tile.scss

+13-5
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,6 @@
1919
.googlesitekit-plugin {
2020

2121
.googlesitekit-widget--connectModuleCTATile {
22-
padding: $grid-gap-phone;
23-
24-
@media (min-width: $bp-desktop) {
25-
padding: $grid-gap-desktop;
26-
}
2722

2823
.googlesitekit-km-connect-module-cta-tile {
2924
align-items: center;
@@ -41,6 +36,19 @@
4136
margin: 0 0 4px;
4237
}
4338

39+
&.googlesitekit-km-widget-tile {
40+
min-height: auto;
41+
padding: 0;
42+
43+
.googlesitekit-km-connect-module-cta-tile {
44+
padding-top: $grid-gap-phone / 2;
45+
46+
@media (min-width: $bp-tablet) {
47+
padding-top: $grid-gap-desktop / 2;
48+
}
49+
}
50+
}
51+
4452
&.googlesitekit-km-widget-tile.googlesitekit-km-widget-tile--combined {
4553
align-items: center;
4654
container: cta-tile / inline-size;

0 commit comments

Comments
 (0)